Fix autocompleting entity layers where id != entity type #2810

New issue

Closed

opened 2015-06-24 10:55:17 +00:00 by wjt · 2 comments

wjt commented

2015-06-24 10:55:17 +00:00

If (for example) you have a type of entities, "participants", and a
second annotation layer for them, like this:

      {
        "id": "participantsdiscussed",
        "title": "Participants discussed",
        "type": "entity",
        "entity": "participants"
      }

then we should be passing key="participants" to autocompleteEntities
(since that is the type of entity), not key="participantsdiscussed"
(which is not a type of entities and raises an error).

If (for example) you have a type of entities, "participants", and a second annotation layer for them, like this: ``` { "id": "participantsdiscussed", "title": "Participants discussed", "type": "entity", "entity": "participants" } ``` then we should be passing key="participants" to autocompleteEntities (since that is the type of entity), not key="participantsdiscussed" (which is not a type of entities and raises an error).

wjt added the

frontend

label 2015-06-24 10:55:17 +00:00

wjt added this to the 14.04 milestone 2015-06-24 10:55:17 +00:00

0x2620 was assigned by wjt

2015-06-24 10:55:17 +00:00

wjt added the

normal

defect

labels 2015-06-24 10:55:17 +00:00

wjt commented

2015-06-24 10:56:17 +00:00

Author

Attachment 0001-Pass-entity-type-to-autocompleteEntities-not-layer-i.patch (1386 bytes) added

Patch: Pass entity type to autocompleteEntities, not layer id (fixes #2810)

**Attachment** 0001-Pass-entity-type-to-autocompleteEntities-not-layer-i.patch (1386 bytes) added Patch: Pass entity type to autocompleteEntities, not layer id (fixes #2810)

0001-Pass-entity-type-to-autocompleteEntities-not-layer-i.patch

1.4 KiB

wjt commented

2015-06-24 14:43:43 +00:00

Author

In [pandora,4998]changeset:"pandora,4998":

#!CommitTicketReference repository="" revision="pandora,4998"
Pass entity type to autocompleteEntities, not layer id (fixes #2810)

If (for example) you have a type of entities, "participants", and a
second annotation layer for them, like this:

    {
        "id": "participantsdiscussed",
        "title": "Participants discussed",
        "type": "entity",
        "entity": "participants"
    }

then we should be passing key="participants" to autocompleteEntities
(since that is the type of entity), not key="participantsdiscussed"
(which is not a type of entities and raises an error).

In [pandora,4998]changeset:"pandora,4998": ``` #!CommitTicketReference repository="" revision="pandora,4998" Pass entity type to autocompleteEntities, not layer id (fixes #2810) If (for example) you have a type of entities, "participants", and a second annotation layer for them, like this: { "id": "participantsdiscussed", "title": "Participants discussed", "type": "entity", "entity": "participants" } then we should be passing key="participants" to autocompleteEntities (since that is the type of entity), not key="participantsdiscussed" (which is not a type of entities and raises an error). ```

wjt added the

fixed

label 2015-06-24 14:43:43 +00:00

wjt closed this issue

2015-06-24 14:43:43 +00:00