0x2620
/
oxjs
2
0
Fork 1
Code Issues 172 Pull Requests Releases Wiki Activity

Use self.pageLength instead of self.options.pageLength in List::getPageByPosition #359

Merged
j merged 1 commits from qsniyg/oxjs:fix-pagelength into master 2023-10-07 09:14:27 +00:00
Conversation 0 Commits 1 Files Changed 1 +1 -1
qsniyg commented 2023-09-04 22:34:34 +00:00
Contributor
Copy Link

self.options.pageLength is a hint, the actual pageLength can differ. For example when orientation == "both", self.options.pageLength is disregarded entirely.

This fixes IconList updates.

`self.options.pageLength` is a hint, the actual `pageLength` can differ. For example when `orientation == "both"`, `self.options.pageLength` is disregarded entirely. This fixes `IconList` updates.
qsniyg added 1 commit 2023-09-04 22:34:34 +00:00
2c4e0b8f7b Use self.pageLength instead of self.options.pageLength in List::getPageByPosition 
self.options.pageLength is a hint, the actual pageLength can differ. For example when orientation == both, self.options.pageLength is disregarded entirely.
j merged commit 2c4e0b8f7b into master 2023-10-07 09:14:27 +00:00
j deleted branch fix-pagelength 2023-10-07 09:14:27 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
0.1

   
0.2

   
0.3

   
1.0

   
Ox

   
Ox.Geo

   
Ox.Image

   
Ox.UI

   
Ox.Unicode

   
critical

   
defect

   
deleteme

   
duplicate

   
enhancement

   
fixed

   
major

   
minor

   
normal

   
severity: major

   
severity: minor

   
severity: normal

   
task

   
trivial

   
wontfix

   
worksforme
No Label
0.1
0.2
0.3
1.0
Ox
Ox.Geo
Ox.Image
Ox.UI
Ox.Unicode
critical
defect
deleteme
duplicate
enhancement
fixed
major
minor
normal
severity: major
severity: minor
severity: normal
task
trivial
wontfix
worksforme
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: 0x2620/oxjs#359
No description provided.
Delete Branch "qsniyg/oxjs:fix-pagelength"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?