From 869de3616340b3b8cd35b36e67f42931780c2590 Mon Sep 17 00:00:00 2001 From: Will Thompson Date: Wed, 22 Jun 2016 15:49:49 +0100 Subject: [PATCH] Fix Ox.Request.cancel(fn) (fixes #2932) arguments[0] === req inside the forEach callback, so previously this would throw TypeError: arguments[0] is not a function --- source/UI/js/Core/Request.js | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/source/UI/js/Core/Request.js b/source/UI/js/Core/Request.js index d8b1f331..cadc6e5a 100644 --- a/source/UI/js/Core/Request.js +++ b/source/UI/js/Core/Request.js @@ -48,8 +48,9 @@ Ox.Request = (function() { requests = {}; } else if (Ox.isFunction(arguments[0])) { // cancel with function + var fn = arguments[0]; Ox.forEach(requests, function(req, id) { - if (arguments[0](req)) { + if (fn(req)) { delete requests[id]; } });