sanj/oxjs
1
0
Fork 0
forked from 0x2620/oxjs
Code Pull requests Activity

avoid leaks by adding custom empty/remove/replaceWith functions to Ox.Element

Browse source
This commit is contained in:
rlx 2011-11-01 19:56:11 +00:00
commit 7848277593
4 changed files with 41 additions and 14 deletions
Download patch file Download diff file Expand all files Collapse all files

19
source/Ox.UI/js/Panel/Ox.SplitPanel.js
View file

@ -46,17 +46,17 @@ Ox.SplitPanel = function(options, self) {
// create elements
that.$elements = [];
self.options.elements.forEach(function(v, i) {
self.options.elements.forEach(function(element, i) {
self.options.elements[i] = Ox.extend({
collapsible: false,
collapsed: false,
resizable: false,
resize: [],
size: 'auto'
}, v);
that.$elements[i] = v.element
.css(self.edges[2], (parseInt(v.element.css(self.edges[2])) || 0) + 'px')
.css(self.edges[3], (parseInt(v.element.css(self.edges[3])) || 0) + 'px');
}, element);
that.$elements[i] = element.element
.css(self.edges[2], (parseInt(element.element.css(self.edges[2])) || 0) + 'px')
.css(self.edges[3], (parseInt(element.element.css(self.edges[3])) || 0) + 'px');
//alert(v.element.css(self.edges[3]))
});
@ -198,8 +198,13 @@ Ox.SplitPanel = function(options, self) {
.css(self.edges[3], (parseInt(element.css(self.edges[3])) || 0) + 'px');
// fixme: it would be better to call removeElement here,
// or have a custom replaceElement function that removes event handlers
self.options.elements[pos].element.replaceWith(element.$element.$element || element.$element);
self.options.elements[pos].element = element;
//self.options.elements[pos].element.replaceWith(element.$element.$element || element.$element)
//self.options.elements[pos].element = element;
///*
self.options.elements[pos].element.replaceWith(
self.options.elements[pos].element = element
);
//*/
setSizes();
self.$resizebars.forEach(function($resizebar, i) {
$resizebar.options({