avoid passing open network connections to subprocesses, call Popen with close_fds=True

2014-09-02 14:24:12 +00:00 · 2014-09-02 14:24:12 +00:00 · 72d9dbf0f2
commit 72d9dbf0f2
parent d5450840ad
7 changed files with 24 additions and 20 deletions
--- a/pandora/text/models.py
+++ b/pandora/text/models.py
@ -255,7 +255,7 @@ class Text(models.Model):
                '-f', ','.join(frames),
                '-o', icon
            ]
-            p = subprocess.Popen(cmd)
+            p = subprocess.Popen(cmd, close_fds=True)
            p.wait()
            self.save()