decentral1se/pandora
1
0
Fork 0
forked from 0x2620/pandora
Code Issues Pull requests Projects Releases Wiki Activity

get_by_key: short-circuit

Browse source 
This is about 30% faster, presumably because it avoids allocation and/or
closing over variables is slow(?). It's not hugely significant (I
misread a line_profile report) but why not.
This commit is contained in:
Will Thompson 2016-03-07 18:52:56 +00:00
parent 7ac68697d4
commit 284caf03c3
1 changed files with 5 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
pandora/item/utils.py
View file

@ -75,8 +75,11 @@ def get_positions(ids, pos):
return positions
def get_by_key(objects, key, value):
obj = filter(lambda o: o.get(key) == value, objects)
return obj and obj[0] or None
for o in objects:
if o.get(key) == value:
return o
return None
def get_by_id(objects, id):
return get_by_key(objects, 'id', id)