0x2620/pandora
2
1
Fork 1
Code Issues 1.3k Pull requests Releases Wiki Activity

Don't fail on Facebook junk in URL #3240

New issue
Closed
opened 2020-04-13 08:38:36 +00:00 by rlx · 6 comments
rlx commented 2020-04-13 08:38:36 +00:00
Owner
Copy link

Example:

FB link https://pad.ma/grid/date/list==zi:Afghan_Films becomes:

https://pad.ma/grid/date/list==zi:Afghan_Films%3Ffbclid%3DIwAR25UNq97L1TrdGAH-GpfERnNXjt7czS6LXuiy7UeMTrUcYlNjOnn8IFCAM

Example: FB link <https://pad.ma/grid/date/list==zi:Afghan_Films> becomes: <https://pad.ma/grid/date/list==zi:Afghan_Films%3Ffbclid%3DIwAR25UNq97L1TrdGAH-GpfERnNXjt7czS6LXuiy7UeMTrUcYlNjOnn8IFCAM>
j added the
general
 label 2020-04-13 08:38:36 +00:00
j added this to the 14.04 milestone 2020-04-13 08:38:36 +00:00
j added the
defect
 label 2020-04-13 08:38:36 +00:00
j commented 2020-05-31 08:52:38 +00:00
Owner
Copy link

fixed in https://wiki.0x2620.org/changeset/ffeee38d7d263727e95c151e317778399a1f6922/oxjs

fixed in <https://wiki.0x2620.org/changeset/ffeee38d7d263727e95c151e317778399a1f6922/oxjs>
j added the
fixed
 label 2020-05-31 08:52:46 +00:00
j closed this issue 2020-05-31 08:52:46 +00:00
rlx commented 2020-08-06 06:01:53 +00:00
Author
Owner
Copy link

The rexexp doesn't handle "-" properly:

Facebook:

https://pad.ma/LAA?fbclid=IwAR2XQYZpziahJTdFYVw_9_K_ZzPzvy6FpXOgFZUgkYZFwkL-b1Fbkhu7l4Q

Pad.ma:

https://pad.ma/grid/created/LAA-b1Fbkhu7l4Q

Everything after "?fbclid=" should be dropped.

The rexexp doesn't handle "-" properly: Facebook: <https://pad.ma/LAA?fbclid=IwAR2XQYZpziahJTdFYVw_9_K_ZzPzvy6FpXOgFZUgkYZFwkL-b1Fbkhu7l4Q> Pad.ma: <https://pad.ma/grid/created/LAA-b1Fbkhu7l4Q> Everything after "?fbclid=" should be dropped.
rlx removed the
fixed
 label 2020-08-06 06:01:53 +00:00
rlx reopened this issue 2020-08-06 06:01:53 +00:00
0x2620 was assigned by rlx 2020-08-06 06:02:21 +00:00
rlx added the
normal
major
major
 labels 2020-08-06 06:02:21 +00:00
rlx commented 2020-08-06 06:12:18 +00:00
Author
Owner
Copy link

Context see screenshot.

Changing the URL to /LAA/info resulted in a faulty URL too, and Facebook didn't even generate the little preview box. Just said "Pad.ma".

Context see screenshot. Changing the URL to /LAA/info resulted in a faulty URL too, and Facebook didn't even generate the little preview box. Just said "Pad.ma".
rlx commented 2020-08-06 06:13:57 +00:00
Author
Owner
Copy link

Attachment Screen Shot 2020-08-06 at 8.10.31 AM.jpg (196468 bytes) added

**Attachment** Screen Shot 2020-08-06 at 8.10.31 AM.jpg (196468 bytes) added
Screen Shot 2020-08-06 at 8.10.31 AM.jpg
192 KiB
Screen Shot 2020-08-06 at 8.10.31 AM.jpg
rlx commented 2020-08-31 20:26:07 +00:00
Author
Owner
Copy link

There is another error:

https://pad.ma/JRM/player/Q?fbclid=IwAR0WbZ4AHNlPcYRG35iOv_YlltjZ_xRUj-BmywHKwrGkUxvSIByZPkJpJWs

becomes:

https://pad.ma/JRM/player/W

There is another error: <https://pad.ma/JRM/player/Q?fbclid=IwAR0WbZ4AHNlPcYRG35iOv_YlltjZ_xRUj-BmywHKwrGkUxvSIByZPkJpJWs> becomes: <https://pad.ma/JRM/player/W>
j commented 2020-08-31 21:12:51 +00:00
Owner
Copy link

In e497e7a/oxjs:

#!CommitTicketReference repository="oxjs" revision="e497e7a7ace5e274030dadcc6c32a8a1a8673894"
remove anything after fbclid=, closes #3240
In [e497e7a/oxjs](https://code.0x2620.org/0x2620/pandora/commit/e497e7a7ace5e274030dadcc6c32a8a1a8673894): ``` #!CommitTicketReference repository="oxjs" revision="e497e7a7ace5e274030dadcc6c32a8a1a8673894" remove anything after fbclid=, closes #3240 ```
j added the
fixed
 label 2020-08-31 21:12:51 +00:00
j closed this issue 2020-08-31 21:12:51 +00:00
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
master
stable
No results found.
Labels
Clear labels   
backend

   
critical

   
defect

   
duplicate

   
enhancement

   
fixed

   
frontend

   
general

   
invalid

   
major

   
minor

   
normal

   
oxjs

   
pandora_client

   
python-ox

   
task

   
trivial

   
wontfix

   
worksforme
No labels
backend
critical
defect
duplicate
enhancement
fixed
frontend
general
invalid
major
minor
normal
oxjs
pandora_client
python-ox
task
trivial
wontfix
worksforme
Milestone
Clear milestone
No items
No milestone
14.04
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
j
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: 0x2620/pandora#3240
No description provided.
Delete branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?