clipList: handle smart lists with no conditions #2884

New issue

Closed

opened 2016-02-19 10:29:35 +00:00 by wjt · 2 comments

wjt commented

2016-02-19 10:29:35 +00:00

I have a smart list which has no conditions (ie matches all items). This
breaks "View as Clips" when the list is selected because:

    pandora.api.getList({id: "wjt:Everything"}) -> {
        // ...
        data: {
            // ...
            query: {}
        }
    }

so result.data.query.conditions is undefined.

I have a smart list which has no conditions (ie matches all items). This breaks "View as Clips" when the list is selected because: ``` pandora.api.getList({id: "wjt:Everything"}) -> { // ... data: { // ... query: {} } } ``` so `result.data.query.conditions` is undefined.

0x2620 added the

frontend

label 2016-02-19 10:29:35 +00:00

0x2620 added this to the 14.04 milestone 2016-02-19 10:29:35 +00:00

0x2620 self-assigned this 2016-02-19 10:29:35 +00:00

0x2620 added the

normal

defect

labels 2016-02-19 10:29:35 +00:00

wjt commented

2016-02-19 10:30:22 +00:00

Author

Attachment 0001-clipList-handle-smart-lists-with-no-conditions-fixes.patch (1391 bytes) added

Also on https://gitlab.com/wjt/pandora.git in 2884-clipList-empty-smart-list

**Attachment** 0001-clipList-handle-smart-lists-with-no-conditions-fixes.patch (1391 bytes) added Also on <https://gitlab.com/wjt/pandora.git> in 2884-clipList-empty-smart-list

0001-clipList-handle-smart-lists-with-no-conditions-fixes.patch

1.4 KiB

j commented

2016-02-20 12:46:16 +00:00

Owner

In e47c652/pandora:

#!CommitTicketReference repository="pandora" revision="e47c652ad0dab503132ed4c1c68c583004a2c25c"
clipList: handle smart lists with no conditions (fixes #2884)

I have a smart list which has no conditions (ie matches all items). This
breaks "View as Clips" when the list is selected because:

    pandora.api.getList({id: "wjt:Everything"}) -> {
        // ...
        data: {
            // ...
            query: {}
        }
    }

so result.data.query.conditions is undefined.

In [e47c652/pandora](https://code.0x2620.org/0x2620/pandora/commit/e47c652ad0dab503132ed4c1c68c583004a2c25c): ``` #!CommitTicketReference repository="pandora" revision="e47c652ad0dab503132ed4c1c68c583004a2c25c" clipList: handle smart lists with no conditions (fixes #2884) I have a smart list which has no conditions (ie matches all items). This breaks "View as Clips" when the list is selected because: pandora.api.getList({id: "wjt:Everything"}) -> { // ... data: { // ... query: {} } } so result.data.query.conditions is undefined. ```

0x2620 added the

fixed

label 2016-02-20 12:46:16 +00:00

j closed this issue

2016-02-20 12:46:16 +00:00