Entity: only update annotations when name has actually changed #2877

New issue

Closed

opened 2016-02-04 18:43:08 +00:00 by wjt · 2 comments

wjt commented

2016-02-04 18:43:08 +00:00

Despite #2827, all the unnecessary updates when an entity's name hasn't changed still offended me, so here's another bandage over that.

0x2620 added the

backend

label 2016-02-04 18:43:08 +00:00

0x2620 added this to the 14.04 milestone 2016-02-04 18:43:08 +00:00

j was assigned by 0x2620

2016-02-04 18:43:08 +00:00

0x2620 added the

normal

enhancement

labels 2016-02-04 18:43:08 +00:00

wjt commented

2016-02-04 18:44:33 +00:00

Author

Attachment 0001-Entity-only-update-annotations-when-name-has-changed.patch (1544 bytes) added

Also on https://gitlab.com/wjt/pandora.git in 2877-Entity.update_annotations

**Attachment** 0001-Entity-only-update-annotations-when-name-has-changed.patch (1544 bytes) added Also on <https://gitlab.com/wjt/pandora.git> in 2877-Entity.update_annotations

0001-Entity-only-update-annotations-when-name-has-changed.patch

1.5 KiB

j commented

2016-02-05 13:36:04 +00:00

Owner

In 691b3fa9/pandora:

#!CommitTicketReference repository="pandora" revision="691b3fa9346ff8488a65017ec223239682394811"
Entity: only update annotations when name has changed (fixes #2877)

Just like ace0468 this doesn't exactly fix #2827, but it does reduce the
unnecessary work.

In [691b3fa9/pandora](https://code.0x2620.org/0x2620/pandora/commit/691b3fa9346ff8488a65017ec223239682394811): ``` #!CommitTicketReference repository="pandora" revision="691b3fa9346ff8488a65017ec223239682394811" Entity: only update annotations when name has changed (fixes #2877) Just like ace0468 this doesn't exactly fix #2827, but it does reduce the unnecessary work. ```

0x2620 added the

fixed

label 2016-02-05 13:36:04 +00:00

j closed this issue

2016-02-05 13:36:04 +00:00