0x2620/pandora
2
1
Fork 1
Code Issues 1.3k Pull requests Releases Wiki Activity

Rename getTaskStatus -> taskStatus in API docs #2859

New issue
Closed
opened 2015-11-20 10:45:21 +00:00 by wjt · 7 comments
wjt commented 2015-11-20 10:45:21 +00:00
Copy link
No description provided.
wjt added the
frontend
 label 2015-11-20 10:45:21 +00:00
wjt added this to the 14.04 milestone 2015-11-20 10:45:21 +00:00
0x2620 was assigned by wjt 2015-11-20 10:45:21 +00:00
wjt added the
trivial
enhancement
 labels 2015-11-20 10:45:21 +00:00
wjt commented 2015-11-20 10:46:07 +00:00
Author
Copy link

Attachment 0001-Rename-getTaskStatus-taskStatus-in-API-docs-fixes-28.patch (1306 bytes) added

**Attachment** 0001-Rename-getTaskStatus-taskStatus-in-API-docs-fixes-28.patch (1306 bytes) added
0001-Rename-getTaskStatus-taskStatus-in-API-docs-fixes-28.patch
1.3 KiB
wjt commented 2016-02-04 14:08:44 +00:00
Author
Copy link

Attachment 0002-addAnnotations-report-which-key-is-missing-in-error.patch (1023 bytes) added

addAnnotations: report which key is missing in error

**Attachment** 0002-addAnnotations-report-which-key-is-missing-in-error.patch (1023 bytes) added addAnnotations: report which key is missing in error
0002-addAnnotations-report-which-key-is-missing-in-error.patch
1,023 B
wjt commented 2016-02-04 14:09:18 +00:00
Author
Copy link

Also available at https://gitlab.com/wjt/pandora.git in the 2859-taskStatus branch.

Also available at <https://gitlab.com/wjt/pandora.git> in the `2859-taskStatus` branch.
Will Thompson commented 2016-02-05 13:30:16 +00:00
Owner
Copy link

In 729856e/pandora:

#!CommitTicketReference repository="pandora" revision="729856eb3054f6390c19958f0b28dd88786bda95"
Rename getTaskStatus -> taskStatus in API docs (fixes #2859)
In [729856e/pandora](https://code.0x2620.org/0x2620/pandora/commit/729856eb3054f6390c19958f0b28dd88786bda95): ``` #!CommitTicketReference repository="pandora" revision="729856eb3054f6390c19958f0b28dd88786bda95" Rename getTaskStatus -> taskStatus in API docs (fixes #2859) ```
0x2620 added the
fixed
 label 2016-02-05 13:30:16 +00:00
Will Thompson closed this issue 2016-02-05 13:30:16 +00:00
rlx commented 2016-02-08 06:50:29 +00:00
Owner
Copy link

Shouldn't the API endpoint be named "getTaskStatus"?

Shouldn't the API endpoint be named "getTaskStatus"?
rlx removed the
fixed
 label 2016-02-08 06:50:29 +00:00
rlx reopened this issue 2016-02-08 06:50:29 +00:00
wjt commented 2016-02-15 14:57:34 +00:00
Author
Copy link

Maybe, but I didn't want to rename it and break existing code. In-tree, it's just importAnnotationsDialog.js as far as I can see; maybe there are other applications using it though, although maybe this bit of documentation:

notes: To be deprecated, will be wrapped in regular API call.

will have discouraged people from using it?

Maybe, but I didn't want to rename it and break existing code. In-tree, it's just `importAnnotationsDialog.js` as far as I can see; maybe there are other applications using it though, although maybe this bit of documentation: notes: To be deprecated, will be wrapped in regular API call. will have discouraged people from using it?
j commented 2016-02-20 13:05:30 +00:00
Owner
Copy link

In 11924fc/pandora:

#!CommitTicketReference repository="pandora" revision="11924fcb0d03ad5e12a734b6c0558df9838ab8de"
Rename api.taskStatus to api.getTaskStatus

still register api.taskStatus since its used
in pandora_client and other scripts.

fixes #2600 and fixes #2859
In [11924fc/pandora](https://code.0x2620.org/0x2620/pandora/commit/11924fcb0d03ad5e12a734b6c0558df9838ab8de): ``` #!CommitTicketReference repository="pandora" revision="11924fcb0d03ad5e12a734b6c0558df9838ab8de" Rename api.taskStatus to api.getTaskStatus still register api.taskStatus since its used in pandora_client and other scripts. fixes #2600 and fixes #2859 ```
0x2620 added the
fixed
 label 2016-02-20 13:05:30 +00:00
j closed this issue 2016-02-20 13:05:30 +00:00
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
master
stable
No results found.
Labels
Clear labels   
backend

   
critical

   
defect

   
duplicate

   
enhancement

   
fixed

   
frontend

   
general

   
invalid

   
major

   
minor

   
normal

   
oxjs

   
pandora_client

   
python-ox

   
task

   
trivial

   
wontfix

   
worksforme
No labels
backend
critical
defect
duplicate
enhancement
fixed
frontend
general
invalid
major
minor
normal
oxjs
pandora_client
python-ox
task
trivial
wontfix
worksforme
Milestone
Clear milestone
No items
No milestone
14.04
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
0x2620
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: 0x2620/pandora#2859
No description provided.
Delete branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?