0x2620/pandora

Clip.save: fetch annotations once, not ~ 2 * n_layers #2838

New issue

Closed

opened 2015-10-02 17:28:45 +00:00 by wjt · 2 comments

wjt commented

2015-10-02 17:28:45 +00:00

With 17 layers and 12 clipLayers, this repeated fetching was around 49%
of the cost of this function, which was in turn 94% of the cost of
creating many new annotations with mostly-unique endpoints. This helps a
bit...

If the order of clipLayers is not meant to be significant to sortvalue
(which I assume it is) then this could be simpler.

With 17 layers and 12 clipLayers, this repeated fetching was around 49% of the cost of this function, which was in turn 94% of the cost of creating many new annotations with mostly-unique endpoints. This helps a bit... If the order of clipLayers is not meant to be significant to sortvalue (which I assume it is) then this could be simpler.

j added the

label 2015-10-02 17:28:45 +00:00

j added this to the 14.04 milestone 2015-10-02 17:28:45 +00:00

j self-assigned this 2015-10-02 17:28:45 +00:00

j added the

labels 2015-10-02 17:28:45 +00:00

wjt commented

2015-10-02 17:31:04 +00:00

Author

Attachment 0001-Clip.save-fetch-annotations-once-not-2-n_layers.patch (2412 bytes) added

**Attachment** 0001-Clip.save-fetch-annotations-once-not-2-n_layers.patch (2412 bytes) added

0001-Clip.save-fetch-annotations-once-not-2-n_layers.patch

2.4 KiB

j commented

2015-10-04 09:22:19 +00:00

Owner

fixed in []changeset:pandora,5037

fixed in []changeset:pandora,5037

j added the

label 2015-10-04 09:22:19 +00:00

j closed this issue

2015-10-04 09:22:19 +00:00

Sign in to join this conversation.

No labels

No milestone

No project

No assignees

2 participants

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: 0x2620/pandora#2838

No description provided.