Can't fully disable subtitles in editor view #2834

New issue

Closed

opened 2015-09-22 12:55:57 +00:00 by wjt · 1 comment

wjt commented

2015-09-22 12:55:57 +00:00

Go to (eg) https://indiancine.ma/ODD/editor/DLS and in the options menu at the top-left of the video, choose Subtitles → None. The subs disappear from the (large) timeline, but not from the video itself.

If I go to the player view and disable subtitles from the menu in the bottom-right of the video, then they disappear in the editor view too. I think I'd expect this setting to be in sync between the editor and the player?

Go to (eg) <https://indiancine.ma/ODD/editor/DLS> and in the options menu at the top-left of the video, choose Subtitles → None. The subs disappear from the (large) timeline, but not from the video itself. If I go to the player view and disable subtitles from the menu in the bottom-right of the video, then they disappear in the editor view too. I think I'd expect this setting to be in sync between the editor and the player?

j added the

frontend

label 2015-09-22 12:55:57 +00:00

j added this to the 14.04 milestone 2015-09-22 12:55:57 +00:00

0x2620 was assigned by j

2015-09-22 12:55:57 +00:00

j added the

normal

defect

labels 2015-09-22 12:55:57 +00:00

j commented

2016-03-05 10:11:05 +00:00

Owner

Fixed in 07ec9317/oxjs:

disable subtitles if disabled via options.enableSubtitles, fixes #2834

Fixed in [07ec9317/oxjs](https://code.0x2620.org/0x2620/pandora/commit/07ec93179cf5878f81731934acc50f10b5bf5eee): > disable subtitles if disabled via options.enableSubtitles, fixes #2834

j added the

fixed

label 2016-03-05 10:11:05 +00:00

j closed this issue

2016-03-05 10:11:05 +00:00