embedTimeline: fix subtitles #2823

New Issue

Closed

opened 2015-08-07 08:28:57 +00:00 by wjt · 3 comments

wjt commented

2015-08-07 08:28:57 +00:00

Fixes this when mousing over an embedded timeline:

TypeError: Array.prototype.slice called on null or undefined
    at Function.Ox.slice.Ox.toArray (http://pandora.local/static/oxjs/dev/Ox/js/Collection.js?0.1.3698:460:34)
    at Function.Ox.forEach (http://pandora.local/static/oxjs/dev/Ox/js/Collection.js?0.1.3698:186:25)
    at getSubtitle (http://pandora.local/static/oxjs/dev/UI/js/Video/VideoTimelinePlayer.js?0.1.3698:532:12)
    at HTMLDivElement.mousemove (http://pandora.local/static/oxjs/dev/UI/js/Video/VideoTimelinePlayer.js?0.1.3698:598:24)
    at HTMLDivElement.jQuery.event.dispatch (http://pandora.local/static/oxjs/dev/UI/jquery/jquery.js?0.1.3698:3256:9)
    at HTMLDivElement.elemData.handle.eventHandle (http://pandora.local/static/oxjs/dev/UI/jquery/jquery.js?0.1.3698:2875:28)

plus a bonus backend error-reporting patch I had lying around in my tree.

Fixes this when mousing over an embedded timeline: ``` TypeError: Array.prototype.slice called on null or undefined at Function.Ox.slice.Ox.toArray (http://pandora.local/static/oxjs/dev/Ox/js/Collection.js?0.1.3698:460:34) at Function.Ox.forEach (http://pandora.local/static/oxjs/dev/Ox/js/Collection.js?0.1.3698:186:25) at getSubtitle (http://pandora.local/static/oxjs/dev/UI/js/Video/VideoTimelinePlayer.js?0.1.3698:532:12) at HTMLDivElement.mousemove (http://pandora.local/static/oxjs/dev/UI/js/Video/VideoTimelinePlayer.js?0.1.3698:598:24) at HTMLDivElement.jQuery.event.dispatch (http://pandora.local/static/oxjs/dev/UI/jquery/jquery.js?0.1.3698:3256:9) at HTMLDivElement.elemData.handle.eventHandle (http://pandora.local/static/oxjs/dev/UI/jquery/jquery.js?0.1.3698:2875:28) ``` plus a bonus backend error-reporting patch I had lying around in my tree.

wjt added the

general

label 2015-08-07 08:28:57 +00:00

wjt added this to the 14.04 milestone 2015-08-07 08:28:57 +00:00

0x2620 was assigned by wjt

2015-08-07 08:28:57 +00:00

wjt added the

normal

defect

labels 2015-08-07 08:28:57 +00:00

wjt commented

2015-08-07 08:29:10 +00:00

Author

Attachment 0001-addClips-return-error-if-item-in-out-missing-not-500.patch (2173 bytes) added

**Attachment** 0001-addClips-return-error-if-item-in-out-missing-not-500.patch (2173 bytes) added

0001-addClips-return-error-if-item-in-out-missing-not-500.patch

2.1 KiB

wjt commented

2015-08-07 08:29:18 +00:00

Author

Attachment 0002-embedTimeline-fix-subtitles.patch (4858 bytes) added

**Attachment** 0002-embedTimeline-fix-subtitles.patch (4858 bytes) added

0002-embedTimeline-fix-subtitles.patch

4.7 KiB

wjt commented

2015-08-07 11:42:58 +00:00

Author

In [pandora,5010]changeset:"pandora,5010":

#!CommitTicketReference repository="" revision="pandora,5010"
embedTimeline: fix subtitles (fixes #2823)

In [pandora,5010]changeset:"pandora,5010": ``` #!CommitTicketReference repository="" revision="pandora,5010" embedTimeline: fix subtitles (fixes #2823) ```

wjt added the

fixed

label 2015-08-07 11:42:58 +00:00

wjt closed this issue

2015-08-07 11:42:58 +00:00