View as Clips when searching for an entity should show the entity's name, not id #2804

New issue

Closed

opened 2015-06-10 10:56:51 +00:00 by wjt · 3 comments

wjt commented

2015-06-10 10:56:51 +00:00

In the Videos view, set the “year” filter to (say) “1952” and the “Locations” filter to (say) “Café”
Choose “View as Clips”

Expected:

A grid of clips, labelled “Café \n 1952”

Actual:

A grid of clips, labelled “NJK \n 1952” – it shows the entity ID rather than the entity, presumably because that is the actual value of the annotation.

* In the Videos view, set the “year” filter to (say) “1952” and the “Locations” filter to (say) “Café” * Choose “View as Clips” Expected: A grid of clips, labelled “Café \n 1952” Actual: A grid of clips, labelled “NJK \n 1952” – it shows the entity ID rather than the entity, presumably because that is the actual value of the annotation.

wjt added the

frontend

label 2015-06-10 10:56:51 +00:00

wjt added this to the 14.04 milestone 2015-06-10 10:56:51 +00:00

0x2620 was assigned by wjt

2015-06-10 10:56:51 +00:00

wjt added the

normal

enhancement

labels 2015-06-10 10:56:51 +00:00

wjt commented

2016-04-19 10:27:00 +00:00

Author

(https://gitlab.com/wjt/pandora.git) branch 2804-clip-entity-names

Here's the diff: https://gitlab.com/wjt/pandora/compare/master...2804-clip-entity-names

I fixed this bug and also made findClips a bit faster. Taken all together, typical findClips calls are 15%-25% faster in my testing, and entity names show up in "View as Clips".

(https://gitlab.com/wjt/pandora.git) branch 2804-clip-entity-names Here's the diff: <https://gitlab.com/wjt/pandora/compare/master...2804-clip-entity-names> I fixed this bug and also made `findClips` a bit faster. Taken all together, typical `findClips` calls are 15%-25% faster in my testing, and entity names show up in "View as Clips".

wjt commented

2016-04-19 11:33:13 +00:00

Author

Pushed a new version which uses Entity.annotation_value to escape entity names (consistent with Annotation.json).

Pushed a new version which uses `Entity.annotation_value` to escape entity names (consistent with `Annotation.json`).

Will Thompson commented

2016-04-26 11:10:46 +00:00

Owner

In 3f5be0b/pandora:

#!CommitTicketReference repository="pandora" revision="3f5be0bd275fdab6464aaf3249ca363fdf1cb677"
findClips: look up entity names (fixes #2804)

In [3f5be0b/pandora](https://code.0x2620.org/0x2620/pandora/commit/3f5be0bd275fdab6464aaf3249ca363fdf1cb677): ``` #!CommitTicketReference repository="pandora" revision="3f5be0bd275fdab6464aaf3249ca363fdf1cb677" findClips: look up entity names (fixes #2804) ```

0x2620 added the

fixed

label 2016-04-26 11:10:46 +00:00

Will Thompson closed this issue

2016-04-26 11:10:46 +00:00