Newly-entered annotation lost if another is immediately created #2801

New Issue

Open

opened 2015-06-04 15:58:46 +00:00 by wjt · 5 comments

wjt commented

2015-06-04 15:58:46 +00:00

(Assume that the third bin of annotations is of type text.)

Open an item in the editor view
Select an in and out point
Hit 3
Type asdf
In very quick succession, hit Enter then 3

Expected result: the annotation asdf is saved, and a new field in the bin is created and is focused for input.

Actual result: the annotation asdf is deleted; either a new empty field is focused, or a phantom empty annotation is left unselected in the bin. If the latter, it will disappear when the item is reloaded.

This happens a lot to users who want to add many tags to a particular region of video and who happen to use this typing pattern. I assume it is a race between the user hitting 3 and the addAnnotation request getting a response.

(Assume that the third bin of annotations is of type text.) 0. Open an item in the editor view 1. Select an in and out point 2. Hit `3` 3. Type `asdf` 4. In very quick succession, hit `Enter` then `3` Expected result: the annotation `asdf` is saved, and a new field in the bin is created and is focused for input. Actual result: the annotation `asdf` is deleted; either a new empty field is focused, or a phantom empty annotation is left unselected in the bin. If the latter, it will disappear when the item is reloaded. This happens a lot to users who want to add many tags to a particular region of video and who happen to use this typing pattern. I assume it is a race between the user hitting `3` and the `addAnnotation` request getting a response.

j added the

frontend

label 2015-06-04 15:58:46 +00:00

j added this to the 14.04 milestone 2015-06-04 15:58:46 +00:00

0x2620 was assigned by j

2015-06-04 15:58:46 +00:00

j added the

normal

defect

labels 2015-06-04 15:58:46 +00:00

j commented

2015-06-06 08:45:50 +00:00

Owner

I would assume the annotation is still saved in that case but does not show up until the site is reloaded.

wjt commented

2015-06-06 14:15:02 +00:00

Author

No, it isn't.

j commented

2015-06-06 14:27:56 +00:00

Owner

ok, in that case i think its related to auto-complete, will try to reproduce. don't quite mange so far

wjt commented

2015-06-09 14:53:08 +00:00

Author

I thought it was to do with auto-complete – the original scenario was "type some letters, choose a match from the autocomplete menu, hit Enter to accept the completion, Enter to commit the theme and 3 to enter a new one". But I can reproduce it without selecting a completion. Try this:

Go to http://DOM.AIN/JE/editor/00:31:55,00:31:34,00:32:04 -- there are no themes at this position (I thought it might be to do with moving the tag to the appropriate sorted position, but it seems to make no difference)
My view settings are Show Annotations: At Current Position; Sort Annotations: By Position; not sure if it makes a difference
Hit 3 to start typing a theme
Type asdf -- there are no themes so named, so the autocomplete menu is empty
Type Enter immediately followed by 3

I'll attach the event log of me doing these steps. A call to addAnnotation with the correct text does make it to the server. Anecdotally, if I don't hit 3 before this call returns, everything is fine; if I do, the client follows up with a removeAnnotation.

I thought it was to do with auto-complete – the original scenario was "type some letters, choose a match from the autocomplete menu, hit `Enter` to accept the completion, `Enter` to commit the theme and `3` to enter a new one". But I can reproduce it without selecting a completion. Try this: * Go to <http://DOM.AIN/JE/editor/00:31:55,00:31:34,00:32:04> -- there are no themes at this position (I thought it might be to do with moving the tag to the appropriate sorted position, but it seems to make no difference) * My view settings are *Show Annotations: At Current Position*; *Sort Annotations: By Position*; not sure if it makes a difference * Hit `3` to start typing a theme * Type `asdf` -- there are no themes so named, so the autocomplete menu is empty * Type `Enter` immediately followed by `3` I'll attach the event log of me doing these steps. A call to `addAnnotation` with the correct text does make it to the server. Anecdotally, if I don't hit 3 before this call returns, everything is fine; if I do, the client follows up with a `removeAnnotation`.

wjt commented

2015-06-09 14:53:28 +00:00

Author

Attachment 3-snth-enter-3.txt (8931 bytes) added

**Attachment** 3-snth-enter-3.txt (8931 bytes) added

3-snth-enter-3.txt

8.7 KiB