0x2620/pandora
2
1
Fork 1
Code Issues 1.3k Pull Requests Releases Wiki Activity

Trying to import broken srt should throw an error #2631

New Issue
Open
opened 2014-12-23 08:00:25 +00:00 by zi · 2 comments
zi commented 2014-12-23 08:00:25 +00:00
Copy Link

Observed on indiancine.ma but most likely issue on pad.ma too:
trying to import a broken srt, dialogue becomes non responsive and shows no indication of failure or srt error. Until one perhaps notices its not showing 'importing xxx annotations...'
After cleaning up / fixing srt, import annots dialog behaves normally as expected.

(Broken srt - had too many line breaks which needed cleaning and some 'special' characters, after which :set nobomb in vi to clear BOM chars)

Observed on indiancine.ma but most likely issue on pad.ma too: trying to import a broken srt, dialogue becomes non responsive and shows no indication of failure or srt error. Until one perhaps notices its not showing 'importing xxx annotations...' After cleaning up / fixing srt, import annots dialog behaves normally as expected. (Broken srt - had too many line breaks which needed cleaning and some 'special' characters, after which :set nobomb in vi to clear BOM chars)
j added the
general
 label 2014-12-23 08:00:25 +00:00
j added this to the 14.04 milestone 2014-12-23 08:00:25 +00:00
0x2620 was assigned by j 2014-12-23 08:00:25 +00:00
j added the
normal
defect
 labels 2014-12-23 08:00:25 +00:00
j commented 2014-12-23 10:59:29 +00:00
Owner
Copy Link

BOM chars should be supported, no need to remove.

BOM chars should be supported, no need to remove.
j commented 2014-12-23 10:59:43 +00:00
Owner
Copy Link

can you upload broken srt for testing

can you upload broken srt for testing
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels   
backend

   
critical

   
defect

   
duplicate

   
enhancement

   
fixed

   
frontend

   
general

   
invalid

   
major

   
minor

   
normal

   
oxjs

   
pandora_client

   
python-ox

   
task

   
trivial

   
wontfix

   
worksforme
No Label
backend
critical
defect
duplicate
enhancement
fixed
frontend
general
invalid
major
minor
normal
oxjs
pandora_client
python-ox
task
trivial
wontfix
worksforme
Milestone
Clear milestone
No items
No Milestone
14.04
Assignees
Clear assignees
No Assignees
0x2620
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: 0x2620/pandora#2631
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?