0x2620
/
pandora
2
1
Fork 1
Code Issues 1.3k Pull Requests Releases Wiki Activity

default locale != current locale != user locale #1762

New Issue
Open
opened 2013-08-04 21:13:00 +00:00 by j · 3 comments
j commented 2013-08-04 21:13:00 +00:00
Owner
Copy Link

once we enable locale, default locale is used if user browser locale does not exist, user locale is used if set and overwrites browser locale,
this has to be reverted:
https://wiki.0x2620.org/changeset/pandora%2C3495

once we enable locale, default locale is used if user browser locale does not exist, user locale is used if set and overwrites browser locale, this has to be reverted: <https://wiki.0x2620.org/changeset/pandora%2C3495>
rlx added the
frontend
 label 2013-08-04 21:13:00 +00:00
rlx self-assigned this 2013-08-04 21:13:00 +00:00
rlx added the
defect
 label 2013-08-04 21:13:00 +00:00
rlx commented 2013-08-04 21:58:13 +00:00
Owner
Copy Link

But pandora.site.user.ui.locale != pandora.user.ui.locale ... the change is just about not storing the same default twice in the same config file (and having the proper locale checked when loading pan.do/ra, currently).

In case we need an empty pandora.site.user.ui.locale later (to tell a new user from an existing user?), the property should be pandora.site.locale, not pandora.site.site.locale.

But pandora.site.user.ui.locale != pandora.user.ui.locale ... the change is just about not storing the same default twice in the same config file (and having the proper locale checked when loading pan.do/ra, currently). In case we need an empty pandora.site.user.ui.locale later (to tell a new user from an existing user?), the property should be pandora.site.locale, not pandora.site.site.locale.
rlx commented 2013-08-04 22:15:29 +00:00
Owner
Copy Link

Thinking about it, storing the site default locale in pandora.site.user.ui.locale should be okay.

If we honor the browser locale on load (i.e. overwrite pandora.user.ui.locale), we should do this not just on first visit, but every time a user loads the page (as the browser locale may have changed). So it doesn't look like an empty ui default buys us much.

Thinking about it, storing the site default locale in pandora.site.user.ui.locale should be okay. If we honor the browser locale on load (i.e. overwrite pandora.user.ui.locale), we should do this not just on first visit, but every time a user loads the page (as the browser locale may have changed). So it doesn't look like an empty ui default buys us much.
rlx added the
critical
normal
 labels 2013-08-04 22:21:23 +00:00
rlx commented 2013-08-06 15:16:25 +00:00
Owner
Copy Link

This can be simplified by adding something like user.ui.useSystemLocale, which defaults to true, and which can be checked/unchecked in the same submenu.

This can be simplified by adding something like user.ui.useSystemLocale, which defaults to true, and which can be checked/unchecked in the same submenu.
rlx added this to the 13.03 milestone 2014-02-10 05:59:04 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
master
stable
Labels
Clear labels   
backend

   
critical

   
defect

   
duplicate

   
enhancement

   
fixed

   
frontend

   
general

   
invalid

   
major

   
minor

   
normal

   
oxjs

   
pandora_client

   
python-ox

   
task

   
trivial

   
wontfix

   
worksforme
No Label
backend
critical
defect
duplicate
enhancement
fixed
frontend
general
invalid
major
minor
normal
oxjs
pandora_client
python-ox
task
trivial
wontfix
worksforme
Milestone
Clear milestone
No items
No Milestone
14.02
Assignees
Clear assignees
No Assignees
rlx
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: 0x2620/pandora#1762
No description provided.
Delete Branch "%!s(<nil>)"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?