0x2620/pandora
2
1
Fork 1
Code Issues 1.3k Pull requests Releases Wiki Activity

Dialogs and menus leave a lot of clutter in the DOM #121

New issue
Closed
opened 2011-11-01 12:31:58 +00:00 by rlx · 3 comments
rlx commented 2011-11-01 12:31:58 +00:00
Owner
Copy link

Every dialog that's ever opened stays in the DOM. Reopening it adds another one. Also, opening a dialog or menu adds a layer to the DOM.

Every dialog that's ever opened stays in the DOM. Reopening it adds another one. Also, opening a dialog or menu adds a layer to the DOM.
rlx added the
frontend
 label 2011-11-01 12:31:58 +00:00
rlx added this to the 11.12 milestone 2011-11-01 12:31:58 +00:00
rlx self-assigned this 2011-11-01 12:31:58 +00:00
rlx added the
major
defect
 labels 2011-11-01 12:31:58 +00:00
rlx commented 2011-11-01 12:47:05 +00:00
Author
Owner
Copy link

For most dialogs, a solution would be to change the idiom from

pandora.$ui.placesDialog = pandora.ui.placesDialog().open();

to

(pandora.$ui.placesDialog || (pandora.$ui.placesDialog = pandora.ui.placesDialog())).open();

This would reopen the dialog in the exact same state.

This won't work for the account dialog, which has to load in a specific state.

For most dialogs, a solution would be to change the idiom from `pandora.$ui.placesDialog = pandora.ui.placesDialog().open();` to `(pandora.$ui.placesDialog || (pandora.$ui.placesDialog = pandora.ui.placesDialog())).open();` This would reopen the dialog in the exact same state. This won't work for the account dialog, which has to load in a specific state.
rlx commented 2011-11-01 14:18:04 +00:00
Author
Owner
Copy link

Layers have been fixed

Layers have been fixed
rlx commented 2012-02-01 14:43:44 +00:00
Author
Owner
Copy link

The "removeOnClose" option takes care of this.

The "removeOnClose" option takes care of this.
rlx added the
fixed
 label 2012-02-01 14:43:44 +00:00
rlx closed this issue 2012-02-01 14:43:44 +00:00
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
master
stable
No results found.
Labels
Clear labels   
backend

   
critical

   
defect

   
duplicate

   
enhancement

   
fixed

   
frontend

   
general

   
invalid

   
major

   
minor

   
normal

   
oxjs

   
pandora_client

   
python-ox

   
task

   
trivial

   
wontfix

   
worksforme
No labels
backend
critical
defect
duplicate
enhancement
fixed
frontend
general
invalid
major
minor
normal
oxjs
pandora_client
python-ox
task
trivial
wontfix
worksforme
Milestone
Clear milestone
No items
No milestone
11.12
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
rlx
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: 0x2620/pandora#121
No description provided.
Delete branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?