Issue with external links on info page

rlx commented

2012-09-29 09:02:56 +00:00

Owner

(like Links: ..., ...)

In Chrome, they get blocked as pop-ups, and when unblocked, open as a chrome-less window.

Links in the list description, for example, work fine (open in a new tab).

(like Links: ..., ...) In Chrome, they get blocked as pop-ups, and when unblocked, open as a chrome-less window. Links in the list description, for example, work fine (open in a new tab).

rlx added the

frontend

label 2012-09-29 09:02:56 +00:00

rlx self-assigned this 2012-09-29 09:02:56 +00:00

rlx added the

defect

label 2012-09-29 09:02:56 +00:00

rlx commented

2012-09-29 12:23:31 +00:00

Author

Owner

Actually, both cases use pandora.clickLink, and the link seems to sometimes open in a new tab, and sometimes in a new window.

Actually, both cases use pandora.clickLink, and the link seems to *sometimes* open in a new tab, and *sometimes* in a new window.

rlx added the

critical

label 2012-09-29 17:21:39 +00:00

j commented

2013-01-25 11:56:44 +00:00

Owner

only way i know that works reliably is to use a links with target, this can not be done from javascript.

j commented

2013-01-25 12:13:39 +00:00

Owner

the problem is in pandora.createLinks, moving
$(e.target).is('a') && pandora.clickLink(e); to the click event it opens properly, in the singleclick the event is no longer triggered by a mouse action and so its considered a popup...

pandora.createLinks = function($element) {
    $element
        .on({
            click: function(e) {
                return false;
            }
        }) 
        .bindEvent({
            singleclick: function(e) {
                $(e.target).is('a') && pandora.clickLink(e);
            }
        });
};

the problem is in pandora.createLinks, moving $(e.target).is('a') && pandora.clickLink(e); to the click event it opens properly, in the singleclick the event is no longer triggered by a mouse action and so its considered a popup... ``` pandora.createLinks = function($element) { $element .on({ click: function(e) { return false; } }) .bindEvent({ singleclick: function(e) { $(e.target).is('a') && pandora.clickLink(e); } }); }; ```

rlx commented

2013-02-11 07:47:29 +00:00

Author

Owner

Is this fixed?

rlx added this to the 13.02 milestone 2013-05-29 08:47:41 +00:00

j added the

fixed

label 2013-07-07 17:38:49 +00:00

j closed this issue

2013-07-07 17:38:49 +00:00

Issue with external links on info page #1040