0x2620/pandora
2
1
Fork 1
Code Issues 1.3k Pull requests Releases Wiki Activity

remove outdated fixmes

Browse source
This commit is contained in:
j 2016-07-01 17:53:59 +02:00
parent d780045306
commit f8f951c966
2 changed files with 0 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
pandora/archive/views.py
View file

@ -258,7 +258,6 @@ def firefogg_upload(request):
f.queued = False f.queued = False
f.wanted = True f.wanted = True
f.save() f.save()
# FIXME: this fails badly if rabbitmq goes down
try: try:
t = f.process_stream() t = f.process_stream()
response['resultUrl'] = t.task_id response['resultUrl'] = t.task_id
@ -477,7 +476,6 @@ def editMedia(request, data):
models.Instance.objects.filter(file__oshash__in=dont_ignore).update(ignore=False) models.Instance.objects.filter(file__oshash__in=dont_ignore).update(ignore=False)
if ignore or dont_ignore: if ignore or dont_ignore:
files = models.File.objects.filter(oshash__in=ignore+dont_ignore) files = models.File.objects.filter(oshash__in=ignore+dont_ignore)
# FIXME: is this to slow to run sync?
for i in Item.objects.filter(files__in=files).distinct(): for i in Item.objects.filter(files__in=files).distinct():
i.update_selected() i.update_selected()
i.update_wanted() i.update_wanted()
@ -624,7 +622,6 @@ def findMedia(request, data):
qs = qs.values('value').annotate(items=Count('id')).order_by(*order_by) qs = qs.values('value').annotate(items=Count('id')).order_by(*order_by)
if 'positions' in query: if 'positions' in query:
# FIXME: this does not scale for larger results
response['data']['positions'] = {} response['data']['positions'] = {}
ids = [j['value'] for j in qs] ids = [j['value'] for j in qs]
response['data']['positions'] = utils.get_positions(ids, query['positions']) response['data']['positions'] = utils.get_positions(ids, query['positions'])
@ -635,7 +632,6 @@ def findMedia(request, data):
else: else:
response['data']['items'] = qs.count() response['data']['items'] = qs.count()
elif 'positions' in query: elif 'positions' in query:
# FIXME: this does not scale for larger results
qs = models.File.objects.filter(item__in=query['qs']) qs = models.File.objects.filter(item__in=query['qs'])
qs = _order_query(qs, query['sort']) qs = _order_query(qs, query['sort'])

1
pandora/item/views.py
View file

@ -598,7 +598,6 @@ def remove(request, data):
item.user == user or \ item.user == user or \
item.groups.filter(id__in=user.groups.all()).count() > 0: item.groups.filter(id__in=user.groups.all()).count() > 0:
add_changelog(request, data) add_changelog(request, data)
# FIXME: is this cascading enough or do we end up with orphan files etc.
item.delete() item.delete()
response = json_response(status=200, text='removed') response = json_response(status=200, text='removed')
else: else: