now that we have js tracebacks, also open dialog for js errors, fixes #2756

This commit is contained in:
j 2015-05-20 11:47:04 +01:00
parent 0e4c49729b
commit d4a7ec0e0c
1 changed files with 27 additions and 29 deletions

View File

@ -141,35 +141,33 @@ pandora.ui.errorlogsDialog = function() {
open: function(data) {
var value = $list.value(Ox.last(data.ids)),
$dialog;
if (/^Traceback/.test(value.text)) {
$dialog = Ox.Dialog({
buttons: [
Ox.Button({
id: 'close',
title: Ox._('Close')
})
.bindEvent({
click: function() {
$dialog.close();
}
})
],
closeButton: true,
content: $('<code>').append(
$('<pre>')
.addClass('OxSelectable')
.css({margin: '16px'})
.text(value.text)
),
height: height - 48,
keys: {enter: 'close', escape: 'close'},
maximizeButton: true,
removeOnClose: true,
title: formatURL(value.url, value.line),
width: width - 48
})
.open();
}
$dialog = Ox.Dialog({
buttons: [
Ox.Button({
id: 'close',
title: Ox._('Close')
})
.bindEvent({
click: function() {
$dialog.close();
}
})
],
closeButton: true,
content: $('<code>').append(
$('<pre>')
.addClass('OxSelectable')
.css({margin: '16px'})
.text(value.text)
),
height: height - 48,
keys: {enter: 'close', escape: 'close'},
maximizeButton: true,
removeOnClose: true,
title: formatURL(value.url, value.line),
width: width - 48
})
.open();
}
}),