From aaacc48259288d0d68dccb1ffbfa578710763a55 Mon Sep 17 00:00:00 2001
From: j <j@mailb.org>
Date: Mon, 20 Jun 2016 18:28:05 +0200
Subject: [PATCH] only save if update_external fails

---
 pandora/item/models.py | 12 +++++-------
 1 file changed, 5 insertions(+), 7 deletions(-)

diff --git a/pandora/item/models.py b/pandora/item/models.py
index 744399f9..b8aa1be1 100644
--- a/pandora/item/models.py
+++ b/pandora/item/models.py
@@ -98,8 +98,8 @@ def get_item(info, user=None):
                     item.external_data = item_data
                 item.user = user
                 item.oxdbId = item.public_id
-                item.save(sync=True)
-                item.update_external()
+                if not item.update_external():
+                    item.save(sync=True)
         else:
             public_id = get_id(info)
             if public_id:
@@ -299,11 +299,9 @@ class Item(models.Model):
             response = external_data('getData', {'id': self.public_id})
             if response['status']['code'] == 200:
                 self.external_data = response['data']
-                p = self.save()
-                if p:
-                    p.wait()
-                else:
-                    self.make_poster(True)
+                self.save(sync=True)
+                return True
+        return False
 
     def add_default_data(self):
         for k in settings.CONFIG['itemKeys']: