0x2620/pandora
2
1
Fork 1
Code Issues 1.3k Pull requests Releases Wiki Activity

only click on links, fixes #1245

Browse source
This commit is contained in:
j 2013-02-13 04:54:16 +00:00
parent 61438b85eb
commit 9b518676ae
1 changed files with 4 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
static/js/pandora/utils.js
View file

@ -218,15 +218,13 @@ pandora.clickLink = function(e) {
pandora.createLinks = function($element) { pandora.createLinks = function($element) {
function isExternalLink(target) { function isExternalLink(target) {
return $(target).is('a') && ( return target.hostname != document.location.hostname
target.hostname != document.location.hostname || Ox.startsWith(target.pathname, '/static');
|| Ox.startsWith(target.pathname, '/static')
)
} }
$element $element
.on({ .on({
click: function(e) { click: function(e) {
if(isExternalLink(e.target)) { if($(e.target).is('a') && isExternalLink(e.target)) {
e.preventDefault(); e.preventDefault();
window.open('/url=' + encodeURIComponent(e.target.href), '_blank'); window.open('/url=' + encodeURIComponent(e.target.href), '_blank');
} }
@ -235,7 +233,7 @@ pandora.createLinks = function($element) {
}) })
.bindEvent({ .bindEvent({
singleclick: function(e) { singleclick: function(e) {
if(!isExternalLink(e.target)) { if($(e.target).is('a') && !isExternalLink(e.target)) {
pandora.clickLink(e); pandora.clickLink(e);
} }
} }