0x2620/pandora
2
1
Fork 1
Code Issues 1.3k Pull requests Releases Wiki Activity

Don't save Document in pre_delete handler (fixes #2889)

Browse source 
FileField.delete() will, by default, save() the model instance it is
attached to. This is pointless if we're in the process of deleting the
Document -- and since Document.save() calls Document.update_matches(),
this scans all annotations every time a document is deleted.
This commit is contained in:
Will Thompson 2016-02-26 11:00:21 +00:00 committed by j
parent 7d99950942
commit 6e0049a20c
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
pandora/document/models.py
View file

@ -302,7 +302,7 @@ def delete_document(sender, **kwargs):
for f in glob('%s/*' % folder): for f in glob('%s/*' % folder):
if f != t.file.path: if f != t.file.path:
os.unlink(f) os.unlink(f)
t.file.delete() t.file.delete(save=False)
pre_delete.connect(delete_document, sender=Document) pre_delete.connect(delete_document, sender=Document)
class ItemProperties(models.Model): class ItemProperties(models.Model):