From 09ebbc9cc6ccf03d3b24c842042ac575749b3abc Mon Sep 17 00:00:00 2001
From: Will Thompson <will@willthompson.co.uk>
Date: Tue, 28 Jun 2016 12:36:07 +0000
Subject: [PATCH] findDocuments: improve performance of positions queries

References #2935
---
 pandora/document/views.py | 30 ++++++++++++++++++++++++++++--
 1 file changed, 28 insertions(+), 2 deletions(-)

diff --git a/pandora/document/views.py b/pandora/document/views.py
index 66a01e59..ab739f62 100644
--- a/pandora/document/views.py
+++ b/pandora/document/views.py
@@ -165,6 +165,33 @@ def parse_query(data, user):
     return query
 
 
+def get_positions(qs, query_positions):
+    '''
+    qs: a QuerySet
+    query_positions: a list of AZ ids
+
+    TODO: merge this with item.utils.get_positions. The win is to fetch
+    only the integer IDs and convert the (smaller) set of query_positions to
+    ints, rather than fetch all keys for everything in qs (expected to be many
+    orders of magnitude larger), ignore most of it, and convert those ids to
+    strings.
+
+    Returns:
+        {
+            i: index of i in qs
+            for i in query_positions
+        }
+    '''
+    ids = list(qs.values_list('id', flat=True))
+    ret = {}
+    for i in query_positions:
+        try:
+            ret[i] = ids.index(ox.fromAZ(i))
+        except:
+            pass
+    return ret
+
+
 def findDocuments(request, data):
     '''
     Finds documents for a given query
@@ -198,8 +225,7 @@ def findDocuments(request, data):
         #FIXME: actually implement position requests
         response['data']['position'] = 0
     elif 'positions' in data:
-        ids = [i.get_id() for i in qs]
-        response['data']['positions'] = utils.get_positions(ids, query['positions'])
+        response['data']['positions'] = get_positions(qs, query['positions'])
     else:
         r = qs.aggregate(
             Sum('size')