examples/maps/map_editor/js/example.js

@@ -16,7 +16,7 @@ Ox.load(['UI', 'Geo'], function() {
             addPlace: function(place, callback) {
                 place = Ox.clone(place)
                 place.id = Ox.encodeBase26((places.length ? Ox.max(places.map(p => Ox.decodeBase26(p.id))) : 0) + 1)
-                place.editable = true;
+                place.editable = true
                 console.log("addPlace", place.id, place)
                 places.push(place)
                 $storage("places", places)

source/UI/js/Map/Map.js

@@ -767,24 +767,34 @@ Ox.Map = function(options, self) {
     }
 
     async function getPlaceByLatLng(latlng, bounds, callback) {
-        // gets the place at latlng appropriate for current zoom level
+        // gets the largest place at latlng that would fit in bounds
         var callback = arguments.length == 3 ? callback : bounds,
             bounds = arguments.length == 3 ? bounds : null;
         self.$loadingIcon && self.$loadingIcon.start();
         var results = await reverseGeocode(latlng);
         self.$loadingIcon && self.$loadingIcon.stop();
-        
         if (results.features.length) {
-            // We only have one result based on current zoom level
+            if (bounds) {
-            var feature = results.features[0];
+                Ox.forEach(results.features, function(result, i) {
-            callback(new Ox.MapPlace(parseGeodata(feature)));
+                    if (
-            
+                        i == results.length - 1 ||
+                        canContain(bounds, result.bounds)
+                    ) {
+                        callback(new Ox.MapPlace(parseGeodata(result)));
+                        return false; // break
+                    }
+                });
+            } else {
+                callback(new Ox.MapPlace(parseGeodata(results.features[0])));
+            }
+        }
+        if (!results.length) {
             triggerGeocodeEvent({
                 latLng: latlng,
-                results: results.features
+                results: results
             });
         } else {
-            Ox.Log('Map', 'geocode failed: no results');
+            Ox.Log('Map', 'geocode failed:', status);
             callback(null);
         }
     }
@@ -885,30 +895,20 @@ Ox.Map = function(options, self) {
 
     async function reverseGeocode(config) {
         const features = [];
-        
-        // Use current map zoom level directly as Nominatim zoom level
-        const currentMapZoom = Math.round(self.map.getZoom());
-        console.log('Reverse geocoding: using map zoom =', currentMapZoom, 'for Nominatim zoom');
-        
         try {
             const request = `${self.options.nominatim}/reverse?lat=${
-                config.lat
+                    config.lat
-            }&lon=${
+                }&lon=${
-                config.lng
+                    config.lng
-            }&format=geojson&polygon_geojson=1&addressdetails=1&zoom=${currentMapZoom}&extratags=1`;
+                }&format=geojson&polygon_geojson=1&addressdetails=1`;
-            
             const response = await fetch(request);
             const geojson = await response.json();
-            
+            for (const feature of geojson.features) {
-            if (geojson.features && geojson.features.length > 0) {
+                features.push(converNominatimFeature(feature));
-                const feature = converNominatimFeature(geojson.features[0]);
-                feature.zoom = currentMapZoom;
-                features.push(feature);
             }
         } catch (e) {
             console.error(`Failed to reverseGeocode with error: ${e}`);
         }
-        
         return {
             features
         };