Commit graph

5 commits

Author SHA1 Message Date
ec85c7b458 Element: faster tooltip event binding
Even when there is no tooltip, setTooltip() accounts for about 5% of the
time spent setting the values on an ArrayEditable, of which about 2% is
Ox.filter.

There only a few possible sets of events, so use object identity rather
than calculating the set difference. In particular, this is a lot faster
when self.options.tooltip is false-y.

(I think it was actually wrong before, anyway:

    bindTooltipEvents({mouseenter, mouseleave})
    bindTooltipEvents({mousemove, mouseleave})

would (correctly) unbind mouseenter and bind mousemove, but would set
boundTooltipEvents = {mousemove} even though mouseleave is still bound.)
2016-06-23 17:56:22 +02:00
3ed5da882f Element: 'fix' mousewheel event before modifying it
In strict mode (in recent browsers), modifying deltaX on a WheelEvent
throws an exception:

Uncaught TypeError: Cannot set property deltaX of #<WheelEvent> which has only a getter

In non-strict mode or older browsers, assigning to deltaX is just a
no-op.

https://github.com/jquery/jquery-mousewheel/blob/master/jquery.mousewheel.js
is cited in this function; it uses $.event.fix() to make a mutable
jQuery.Event-flavoured copy of the native event before modifying its
properties. Let's do the same.

Fixes #2751
2015-05-20 12:33:44 +02:00
j
c7bf33fdfe expose new Ox.Element as in setElement 2015-03-24 19:07:23 +05:30
j
6b9b86e95a fix iframe init, compare to timestamp not date string 2014-10-09 12:56:13 +02:00
rolux
51696562f1 remove unneeded Ox. prefix from path and file names 2014-09-26 15:51:50 +02:00
Renamed from source/Ox.UI/js/Core/Element.js (Browse further)