Commit graph

140 commits

Author SHA1 Message Date
adbf2dad81 ArrayEditable: replace self.$items
When shrinking the number of items, this allows the old elements to be
GCed sooner.
2016-06-23 17:56:22 +02:00
84b3c34130 Editable: avoid setTimeout
It's easily avoided and clearer without it.
2016-06-23 17:56:22 +02:00
ec85c7b458 Element: faster tooltip event binding
Even when there is no tooltip, setTooltip() accounts for about 5% of the
time spent setting the values on an ArrayEditable, of which about 2% is
Ox.filter.

There only a few possible sets of events, so use object identity rather
than calculating the set difference. In particular, this is a lot faster
when self.options.tooltip is false-y.

(I think it was actually wrong before, anyway:

    bindTooltipEvents({mouseenter, mouseleave})
    bindTooltipEvents({mousemove, mouseleave})

would (correctly) unbind mouseenter and bind mousemove, but would set
boundTooltipEvents = {mousemove} even though mouseleave is still bound.)
2016-06-23 17:56:22 +02:00
db343c382e ArrayEditable: one tooltip, not one per element
When changing the visible annotations in the bins in Pandora, creating
(and destroying) all the Ox.Tooltips takes a substantial fraction of the
time. So instead, maintain only one tooltip for each ArrayEditable.
2016-06-23 17:56:22 +02:00
869de36163
Fix Ox.Request.cancel(fn) (fixes #2932)
arguments[0] === req inside the forEach callback, so previously this
would throw

    TypeError: arguments[0] is not a function
2016-06-22 15:53:18 +01:00
j
af610a0df9 work around mobile interaction restrictions 2016-05-17 17:40:40 +02:00
j
5073700241 add keyboard shortcut to toggle playback rate between 1 and 2 2016-03-29 14:57:42 +02:00
j
f2e7c75d2c add playbackRate to video elements 2016-03-29 14:26:04 +02:00
j
da08120ff4 selected item might be gone 2016-03-16 08:29:31 +01:00
j
cb875c86df fix subtitle toggle in edit panel too 2016-03-05 16:27:29 +05:30
j
ab21bdbe25 fix subtitle selection in player menu 2016-03-05 16:10:24 +05:30
j
07ec93179c disable subtitles if disabled via options.enableSubtitles, fixes #2898 2016-03-05 15:38:52 +05:30
3637b70244 Autocomplete: only replace input when a prefix matches (fixes #2753)
Previously, if the top match for "Smi" was "John Smith", the contents of
the field would be changed to "Smi[n Smith]" (where square brackets
indicate selection). On top of this, if you then type the fourth letter
("n"), the input becomes "Smin", which is not what you typed.

This preserves the "happy path" for replacing the field contents if
there is a prefix match, but without making the field unusable if
there's an infix match.
2016-03-02 17:08:45 +00:00
rlx
d9ef18d482 indeterminate checkboxes... 2016-02-10 13:24:57 +05:30
rlx
2944379b71 indeterminate checkboxes... 2016-02-10 13:22:38 +05:30
rlx
1472927883 indeterminate checkboxes... 2016-02-10 13:19:45 +05:30
rlx
6d560fc4f5 indeterminate checkboxes... 2016-02-10 13:17:17 +05:30
rlx
ff30b32188 indeterminate checkboxes... 2016-02-10 13:15:15 +05:30
rlx
5ea5a5ee2b indeterminate checkboxes... 2016-02-10 13:10:38 +05:30
rlx
56c72ba0b4 'minus' -> 'remove' 2016-02-10 13:08:10 +05:30
rlx
4248a3a783 indeterminate checkboxes... 2016-02-10 13:06:15 +05:30
rlx
12c466b0d3 indeterminate checkboxes... 2016-02-10 13:04:39 +05:30
rlx
0dd921caae indeterminate checkboxes... 2016-02-10 13:03:36 +05:30
rlx
368ae04fe0 Ox.Checkbox: add indeterminate option 2016-02-10 12:56:19 +05:30
j
0327947864 fix form_elements example 2016-01-30 22:39:45 +05:30
rlx
396c69333e Edits: fix doubleclick-to-scroll-to-top in list view 2016-01-21 12:54:25 +05:30
rlx
731c2e88fe Filter: handle formatISBN 2016-01-17 16:44:59 +05:30
rlx
835122967f whitespace 2016-01-13 14:56:13 +05:30
rlx
3f4fa3b1fe support for squared select inputs 2016-01-13 14:17:31 +05:30
rlx
1734bcc66f allow for squared-styled progress bars 2016-01-12 19:01:15 +05:30
rlx
32252a1dfd some more support for squared style 2016-01-12 11:11:08 +05:30
rlx
53bc6e9e56 checkboxes: allow for squared style 2016-01-12 09:50:00 +05:30
j
19be508afe Fix pending requests: depend on data not id. 2016-01-02 19:31:56 +05:30
b0853447d1 AnnotationPanel: allow sorting by creation time
fixes #2865
2015-12-14 13:06:03 +00:00
rolux
511a5267b5 Ox.Map: remove terms reformatting 2015-10-30 10:51:53 +01:00
j
fc4dc70545 fix mouse zoom in imageview on linux 2015-10-22 11:33:37 +02:00
j
7516c940f5 use default value instead of '', fixes #2848 2015-10-12 15:41:11 +01:00
j
5bdc80a24f split clip at position 2015-10-04 16:08:44 +01:00
j
2d5ad4500e use Ox.sort, fixes #2802 2015-06-25 14:28:56 +02:00
j
24027c0bcb pass empty string instead of undefined to Ox.words 2015-05-23 13:25:22 +02:00
j
6988dfa89f don't break on unknown keys 2015-05-23 13:02:39 +02:00
3ed5da882f Element: 'fix' mousewheel event before modifying it
In strict mode (in recent browsers), modifying deltaX on a WheelEvent
throws an exception:

Uncaught TypeError: Cannot set property deltaX of #<WheelEvent> which has only a getter

In non-strict mode or older browsers, assigning to deltaX is just a
no-op.

https://github.com/jquery/jquery-mousewheel/blob/master/jquery.mousewheel.js
is cited in this function; it uses $.event.fix() to make a mutable
jQuery.Event-flavoured copy of the native event before modifying its
properties. Let's do the same.

Fixes #2751
2015-05-20 12:33:44 +02:00
j
6a5cb61880 fix subtitle offset 2015-04-21 16:40:35 +05:30
j
1b18ade72c fix video offset 2015-04-21 16:04:45 +05:30
rolux
fc982fe775 de-refactoring 2015-04-20 09:50:46 +02:00
rolux
cbcfbe8340 animate subtitles on toggle scale 2015-04-20 09:43:01 +02:00
rolux
d437d95f96 fix subtitles css for 'scale to fill' case 2015-04-20 09:39:33 +02:00
j
160c38c361 bind e to show entity info 2015-04-17 13:06:35 +05:30
j
4f7b9846d8 entities are not links 2015-04-16 20:03:38 +00:00
j
f624c86309 decode html entities 2015-04-17 01:09:36 +05:30