0x2620/oxjs
2
0
Fork 1
Code Issues 172 Pull requests Releases Wiki Activity

use [].slice, not Ox.sub

Browse source
This commit is contained in:
rolux 2012-05-24 11:02:59 +02:00
parent 915e98f829
commit f990f3b857
7 changed files with 10 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
source/Ox.UI/js/Code/Ox.SourceViewer.js
View file

@ -46,7 +46,7 @@ Ox.SourceViewer = function(options, self) {
if (!/^\/\//.test(text)) { if (!/^\/\//.test(text)) {
if (type == 'comment') { if (type == 'comment') {
i && sections.push({comment: '', code: ''}); i && sections.push({comment: '', code: ''});
text = Ox.sub(text, 2, -2); text = text.slice(2, -2);
self.options.replaceComment.forEach(function(replace) { self.options.replaceComment.forEach(function(replace) {
text = text.replace(replace[0], replace[1]); text = text.replace(replace[0], replace[1]);
}); });

2
source/Ox.UI/js/Core/Ox.URL.js
View file

@ -397,7 +397,7 @@ Ox.URL = function(options) {
var ret; var ret;
if (condition[0] == '(') { if (condition[0] == '(') {
// re-insert subcondition // re-insert subcondition
ret = parseFind(subconditions[parseInt(Ox.sub(condition, 1, -1))]); ret = parseFind(subconditions[parseInt(condition.slice(1, -1))]);
} else { } else {
ret = parseCondition(condition); ret = parseCondition(condition);
} }

2
source/Ox.UI/js/Video/Ox.VideoElement.js
View file

@ -116,7 +116,7 @@ Ox.VideoElement = function(options, self) {
if (Ox.every(item.durations)) { if (Ox.every(item.durations)) {
item.duration = Ox.sum(item.durations); item.duration = Ox.sum(item.durations);
item.offsets = Ox.range(item.parts).map(function(i) { item.offsets = Ox.range(item.parts).map(function(i) {
return Ox.sum(Ox.sub(item.durations, 0, i)); return Ox.sum(item.durations.slice(0, i));
}); });
//Ox.Log('Video', 'METADATA OF', src, 'LOADED', item) //Ox.Log('Video', 'METADATA OF', src, 'LOADED', item)
if (self.isPlaylist) { if (self.isPlaylist) {

4
source/Ox.UI/js/Window/Ox.Dialog.js
View file

@ -498,8 +498,8 @@ Ox.Dialog = function(options, self) {
buttonsRight, buttonsRight,
index = Ox.indexOf(self.options.buttons, Ox.isEmpty); index = Ox.indexOf(self.options.buttons, Ox.isEmpty);
if (index) { if (index) {
buttonsLeft = Ox.sub(self.options.buttons, 0, index); buttonsLeft = self.options.buttons.slice(0, index);
buttonsRight = Ox.sub(self.options.buttons, index + 1); buttonsRight = self.options.buttons.slice(index + 1);
} else { } else {
buttonsLeft = []; buttonsLeft = [];
buttonsRight = self.options.buttons; buttonsRight = self.options.buttons;

4
source/Ox/js/Array.js
View file

@ -214,8 +214,8 @@ Ox.api = function(items, options) {
} }
if (options.range) { if (options.range) {
// apply range // apply range
result.data.items = Ox.sub( result.data.items = result.data.items.slice(
result.data.items, options.range[0], options.range[1] options.range[0], options.range[1]
); );
} }
} }

4
source/Ox/js/Geo.js
View file

@ -314,7 +314,7 @@
} }
}; };
} }
Ox.forEach(Ox.sub(areas, 1), function(parts) { Ox.forEach(areas.slice(1), function(parts) {
if (ret.length == 1 && parts.length == 1) { if (ret.length == 1 && parts.length == 1) {
ret = intersect(ret[0], parts[0]); ret = intersect(ret[0], parts[0]);
} else { } else {
@ -383,7 +383,7 @@
}); });
return ret; return ret;
} }
Ox.sub(areas, 1).forEach(function(area) { areas.slice(1).forEach(function(area) {
var index, indices, intersections; var index, indices, intersections;
if (area.sw.lat < ret.sw.lat) { if (area.sw.lat < ret.sw.lat) {
ret.sw.lat = area.sw.lat; ret.sw.lat = area.sw.lat;

2
source/Ox/js/JavaScript.js
View file

@ -280,7 +280,7 @@ Ox.doc = (function() {
} }
}); });
function unwrap(str) { function unwrap(str) {
return (isArray = /^\[.+\]$/.test(str)) ? Ox.sub(str, 1, -1) : str; return (isArray = /^\[.+\]$/.test(str)) ? str.slice(1, -1) : str;
} }
function wrap(str) { function wrap(str) {
return isArray ? '[' + str + 's' + ']' : str; return isArray ? '[' + str + 's' + ']' : str;