0x2620/oxjs
2
0
Fork 1
Code Issues 172 Pull requests Releases Wiki Activity

Ox.List: change 'selected' update handler

Browse source
This commit is contained in:
rlx 2012-06-30 15:05:05 +00:00
parent f5901e4a1d
commit d57affea4a
1 changed files with 6 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
source/Ox.UI/js/List/List.js
View file

@ -109,13 +109,11 @@ Ox.List = function(options, self) {
}, },
selected: function() { selected: function() {
var previousSelected = Ox.clone(self.selected); var previousSelected = Ox.clone(self.selected);
setSelected(self.options.selected); setSelected(self.options.selected, function() {
// fixme: the following was added in order if (!Ox.isEqual(self.selected, previousSelected)) {
// to make table list find-as-you-type work,
// this may break other things
if (/*!self.isAsync && */!Ox.isEqual(self.selected, previousSelected)) {
triggerSelectEvent(self.options.selected); triggerSelectEvent(self.options.selected);
} }
});
}, },
sort: function() { sort: function() {
updateSort(); updateSort();
@ -1207,7 +1205,6 @@ Ox.List = function(options, self) {
} }
function setSelected(ids, callback) { function setSelected(ids, callback) {
// fixme: no case where callback is set
// note: can't use selectNone here, // note: can't use selectNone here,
// since it'd trigger a select event // since it'd trigger a select event
Ox.Log('List', 'SET SELECTED', ids) Ox.Log('List', 'SET SELECTED', ids)
@ -1725,11 +1722,10 @@ Ox.List = function(options, self) {
(id) -> <o> returns all values of id (id) -> <o> returns all values of id
id <s> id of item id <s> id of item
key <s> key if item property key <s> key if item property
value <s> value, can be whatever that property is value <*> value, can be whatever that property is
@*/ @*/
that.value = function(id, key, value) { that.value = function(id, key, value) {
// id can be a number and will then be interpreted as position // id can be a number and will then be interpreted as position
Ox.Log('List', 'that.value id key value', id, key, value)
var pos = Ox.isNumber(id) ? id : getPositionById(id), var pos = Ox.isNumber(id) ? id : getPositionById(id),
$item = self.$items[pos], $item = self.$items[pos],
data = $item ? $item.options('data') : {}; data = $item ? $item.options('data') : {};