diff --git a/source/Ox.UI/js/List/Ox.TreeList.js b/source/Ox.UI/js/List/Ox.TreeList.js index ebcb291a..806f40e4 100644 --- a/source/Ox.UI/js/List/Ox.TreeList.js +++ b/source/Ox.UI/js/List/Ox.TreeList.js @@ -47,7 +47,7 @@ Ox.TreeList = function(options, self) { max: self.options.max, min: self.options.min, unique: 'id' - }, Ox.copy(self)) + }, Ox.clone(self)) .addClass('OxTextList OxTreeList') .css({ width: self.options.width + 'px', @@ -160,8 +160,8 @@ Ox.TreeList = function(options, self) { if (type == 'array' || type == 'object') { ret.title += Ox.toTitleCase(type) + ' [' + Ox.len(value) + ']'; - ret.items = Ox.sort(Ox.keys(value).map(function(k) { - return parseData(k, value[k]); + ret.items = Ox.sort(Ox.map(value, function(v, k) { + return parseData(k, v); })); } else { ret.title += ( diff --git a/source/Ox/js/Array.js b/source/Ox/js/Array.js index 3288efe3..91a46ec5 100644 --- a/source/Ox/js/Array.js +++ b/source/Ox/js/Array.js @@ -344,7 +344,6 @@ Ox.flatten Flattens an array [1, 2, 3, 2, 1] @*/ Ox.flatten = function(arr) { - // fixme: can this work for objects too? var ret = []; arr.forEach(function(val) { if (Ox.isArray(val)) { @@ -579,4 +578,4 @@ Ox.zip = function() { }); }); return arr; -}; \ No newline at end of file +}; diff --git a/source/Ox/js/Collection.js b/source/Ox/js/Collection.js index 5c3f3265..1c5fce29 100644 --- a/source/Ox/js/Collection.js +++ b/source/Ox/js/Collection.js @@ -188,8 +188,8 @@ Ox.forEach = function(col, fn, that) { } } else { for (i = 0; i < col.length; i++) { - // fn.call(that, col[i], i, col); - if (fn.call(that, col[i], i, col) === false) { + // i in col && fn.call(that, col[i], i, col); + if (i in col && fn.call(that, col[i], i, col) === false) { console.warn('Returning false in Ox.forEach is deprecated.') break; } @@ -304,8 +304,12 @@ Ox.indexOf = function(col, fn) { return index == col.length ? -1 : index; }; -// FIXME: use this instead of `Ox.filter(Ox.map())` when it's just about getting -// the original indices +/*@ +Ox.indicesOf return indices of array elements that pass a test + > Ox.indicesOf([1, 2, 3, 4], function(val) { return val % 2 == 0; }) + [1, 3] + +@*/ Ox.indicesOf = function(col, fn) { return Ox.map(col, function(val, i) { return fn(val) ? i : null; @@ -339,31 +343,6 @@ Ox.isEmpty = function(val) { return Ox.len(val) === 0; }; -/*@ -Ox.keys Returns the keys of a collection - Unlike Object.keys(), Ox.keys() works for arrays, - objects and strings. - > Ox.keys([1, 2, 3]) - [0, 1, 2] - > Ox.keys([1,,3]) - [0, 2] - # fixme? - # > Ox.keys([,]) - # [0] - > Ox.keys({a: 1, b: 2, c: 3}) - ['a', 'b', 'c'] - > Ox.keys('abc') - [0, 1, 2] -@*/ -// fixme: is this really needed? arrays... ok... but strings?? -Ox.keys = function(obj) { - var keys = []; - Ox.forEach(obj, function(v, k) { - keys.push(k); - }); - return keys.sort(); -}; - /*@ Ox.last Gets or sets the last element of an array Unlike arrayWithALongName[arrayWithALongName.length - 1], @@ -395,7 +374,7 @@ Ox.last = function(arr, val) { Ox.len Returns the length of an array, node list, object or string Not to be confused with Ox.length, which is the length property of the Ox function - (1). // FIXME: 1 becomes 67 in DocPanel + (1). > Ox.len((function() { return arguments; }(1, 2, 3))) 3 > Ox.len([1, 2, 3]) @@ -480,9 +459,8 @@ Ox.map Transforms the values of an array, object or string [true, false, false] > Ox.map([0, 1, 2, 4], function(v, i) { return v ? i == v : null; }) [true, true, false] - # fixme? - # > Ox.map([,], function(v, i) { return i; }) - # [0] + > Ox.map([,], function(v, i) { return i; }) + [,] @*/ Ox.map = function(col, fn, that) { var type = Ox.typeOf(col), ret; @@ -593,23 +571,25 @@ Ox.shuffle Randomizes the order of values within a collection > Ox.shuffle('123').split('').sort().join('') '123' @*/ -// FIXME: this doesn't actually randomize the order Ox.shuffle = function(col) { var keys, ret, type = Ox.typeOf(col), values; - function sort() { - return Math.random() - 0.5; - } - if (type == 'array') { - ret = col.sort(sort); - } else if (type == 'object') { + if (type == 'object') { keys = Object.keys(col); - values = Ox.values(col).sort(sort); + values = Ox.shuffle(Ox.values(col)); ret = {}; keys.forEach(function(key, i) { ret[key] = values[i] }); - } else if (type == 'string') { - ret = col.split('').sort(sort).join(''); + } else { + ret = []; + Ox.toArray(col).forEach(function(v, i) { + var random = Math.floor(Math.random() * (i + 1)); + ret[i] = ret[random]; + ret[random] = v; + }); + if (type == 'string') { + ret = ret.join(''); + } } return ret; }; diff --git a/source/Ox/js/DOM.js b/source/Ox/js/DOM.js index 230a64bf..9cafd053 100644 --- a/source/Ox/js/DOM.js +++ b/source/Ox/js/DOM.js @@ -78,13 +78,10 @@ Ox.$ Generic HTML element, mimics jQuery 'red' @*/ Ox.$ = Ox.element = function(val) { - // fixme: remove click and mousedown, - // add native css selector - // take all matches of getElementsBy... var element = !Ox.isString(val) ? val // window or document - : val[0] == '<' ? document.createElement(Ox.sub(val, 1, -1)) - : val[0] == '#' ? document.getElementById(Ox.sub(val, 1)) - : val[0] == '.' ? document.getElementsByClassName(Ox.sub(val, 1))[0] + : val[0] == '<' ? document.createElement(val.slice(1, -1)) + : val[0] == '#' ? document.getElementById(val.slice(1)) + : val[0] == '.' ? document.getElementsByClassName(val.slice(1))[0] : document.getElementsByTagName(val)[0]; return element ? { //@ 0 The DOM element itself @@ -327,4 +324,4 @@ Ox.$ = Ox.element = function(val) { return this[0].offsetWidth; } } : null; -}; \ No newline at end of file +}; diff --git a/source/Ox/js/HTML.js b/source/Ox/js/HTML.js index c7615c7b..897f5fb4 100644 --- a/source/Ox/js/HTML.js +++ b/source/Ox/js/HTML.js @@ -99,7 +99,7 @@ Ox.parseHTML = (function() { //html = Ox.parseURLs(html); //html = Ox.parseEmailAddresses(html); matches.forEach(function(match, i) { - html = html.replace(new RegExp(tab + i + tab, 'gi'), match); + html = html.replace(new RegExp(tab + i + tab), match); }); html = html.replace(/\n\n/g, '

'); // close extra opening (and remove extra closing) tags diff --git a/source/Ox/js/JavaScript.js b/source/Ox/js/JavaScript.js index 2812f5a2..4081d1ca 100644 --- a/source/Ox/js/JavaScript.js +++ b/source/Ox/js/JavaScript.js @@ -42,7 +42,7 @@ Ox.doc Generates documentation for annotated JavaScript Ox.doc = (function() { // fixme: dont require the trailing '@' var re = { - item: /^(.+?) <(.+?)>(.*?)$/, + item: /^(.+?) <(.+?)> (.+?)$/, multiline: /^\/\*\@.*?\n([\w\W]+)\n.*?\@\*\/$/, script: /\n(\s*