minor changes

This commit is contained in:
rolux 2011-11-30 15:56:01 +01:00
parent 8e68992ea0
commit 137944a1a7
6 changed files with 10 additions and 2 deletions

View file

@ -48,7 +48,7 @@ Ox.Form = function(options, self) {
self.itemIsValid[i] = item.value().length > 0; self.itemIsValid[i] = item.value().length > 0;
} }
self.itemIds[i] = item.options('id') || item.id; self.itemIds[i] = item.options('id') || item.id;
that.append(self.$items[i] = Ox.FormItem({element: item})); self.$items[i] = Ox.FormItem({element: item}).appendTo(that);
item.bindEvent({ item.bindEvent({
/* /*
blur: function(data) { blur: function(data) {

View file

@ -138,6 +138,8 @@ Ox.PlacePicker = function(options, self) {
self.$map = Ox.Map({ self.$map = Ox.Map({
clickable: true, clickable: true,
id: self.options.id + 'Map', id: self.options.id + 'Map',
// fixme: this is retarded, allow for map without places
places: [{south: -85, west: -179, north: -85, east: 179}]
//places: [self.options.value] //places: [self.options.value]
}) })
.css({ .css({

View file

@ -231,6 +231,7 @@ Ox.Range = function(options, self) {
} }
function setTrackColors() { function setTrackColors() {
// fixme: remove outdated -webkit format, and add -o
self.$track.css({ self.$track.css({
backgroundImage: $.browser.mozilla ? backgroundImage: $.browser.mozilla ?
('-moz-linear-gradient(left, ' + ('-moz-linear-gradient(left, ' +

View file

@ -59,7 +59,7 @@ Ox.TextList = function(options, self) {
columnWidth: [40, 800], columnWidth: [40, 800],
draggable: false, draggable: false,
id: '', id: '',
items: null, // function() {} {sort, range, keys, callback} or array items: null,
keys: [], keys: [],
max: -1, max: -1,
min: 0, min: 0,

View file

@ -495,6 +495,9 @@ Ox.map <f> Transforms the values of an array, object or string
# [0] # [0]
@*/ @*/
// FIXME: it would sometimes be nice to have Ox.map(3, function(i) {...})
// instead of Ox.range(3).map(function(i) {...})
Ox.map = function(obj, fn) { Ox.map = function(obj, fn) {
// fixme: return null to filter out may be a bit esoteric // fixme: return null to filter out may be a bit esoteric
var isObject = Ox.isObject(obj), var isObject = Ox.isObject(obj),

View file

@ -70,6 +70,8 @@ Some conventions:
: expression; : expression;
*/ */
// FIXME: add memoize
// todo: check http://ejohn.org/blog/ecmascript-5-strict-mode-json-and-more/ // todo: check http://ejohn.org/blog/ecmascript-5-strict-mode-json-and-more/
// also see https://github.com/tlrobinson/narwhal/blob/master/lib/util.js // also see https://github.com/tlrobinson/narwhal/blob/master/lib/util.js